-
Notifications
You must be signed in to change notification settings - Fork 0
[JNI] Version 0.2.0
#42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1bca2f0 to
e4dad95
Compare
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
e4dad95 to
ce17798
Compare
elenagaljak-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the files in resources/native? Do we need to keep them in the repo?
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
Once again, LLM explains it better then I would. 🙂 What they are:These are pre-compiled native JNI libraries built from the https://github.com/databricks/zerobus-sdk-rs. The Java SDK calls into these via JNI for high-performance ingestion. Why they're in the repo:
Do we need to keep them?Yes, unless we change the distribution model to either:
The current approach (bundled in JAR) is the standard pattern for JNI libraries (similar to how SQLite JDBC, RocksDB Java, etc. distribute their natives). |
Okay but what about MacOS? |
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
I've managed to add both MacOS platforms, thanks! |
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
elenagaljak-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
What changes are proposed in this pull request?
How is this tested?
Unit and integration tests, examples.